Skip to content

refactor: use Python 3, has latest pip for cobra - #187

Merged
haowang-bioinfo merged 7 commits into
develfrom
refactor/yaml-validation-workflow
Jul 21, 2020
Merged

refactor: use Python 3, has latest pip for cobra#187
haowang-bioinfo merged 7 commits into
develfrom
refactor/yaml-validation-workflow

Conversation

@mihai-sysbio

@mihai-sysbio mihai-sysbio commented Jul 15, 2020

Copy link
Copy Markdown
Member

Main improvements in this PR:

This PR migrates Python to version 3, which removes the need to upgrade pip before installing cobra. It also addresses the FutureWarning message which cobrapy outputs.

@mihai-sysbio

Copy link
Copy Markdown
Member Author

Great improvement @Hao-Chalmers 👍 for the action to pass it needs the model file in the new location, ie #188 should be merged first.

@haowang-bioinfo
haowang-bioinfo self-requested a review July 20, 2020 08:38
@JonathanRob

Copy link
Copy Markdown
Collaborator

Agreed, nice addition, @Hao-Chalmers.

A small question - should this new basicCheck.py script be placed in the .github/workflows/ directory?

@haowang-bioinfo

Copy link
Copy Markdown
Contributor

@JonathanRob not sure about the location. @mihai-sysbio what do you think?

Some thoughts about basicCheck: now it has checks for cobrapy import and consistency with annotation files. More tests may be added later either by curator or user, to whom the code/test folder probably is better to work with?

@mihai-sysbio

Copy link
Copy Markdown
Member Author

Imho tests should be designed to run on their own, and just called in the workflow, so that users can have the freedom of testing whenever they prefer; I'd leave tests in code/test.

@JonathanRob

Copy link
Copy Markdown
Collaborator

Ok, sounds good @mihai-sysbio @Hao-Chalmers! No need to move things around then.

@haowang-bioinfo
haowang-bioinfo merged commit 292b284 into devel Jul 21, 2020
@haowang-bioinfo
haowang-bioinfo deleted the refactor/yaml-validation-workflow branch July 21, 2020 12:57
@haowang-bioinfo haowang-bioinfo mentioned this pull request Jul 23, 2020
migp11 added a commit to bsc-life/Human-GEM that referenced this pull request May 10, 2024
edkerk pushed a commit that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants