Human v1.3.2 - #168
Merged
Merged
Conversation
The original error could not be reproduced
metabolites were imported from iHsa but are not involved in any reactions.
dash causes problems when exporting to SBML
Also adds "spontaneous" field to humanGEMRxnAssoc.JSON
feat: add gene associations to four mitochondrial transport reactions
Fix: standardize EC codes and remove orphan metabolites
update README with references/links to the Human-GEM user guide
fix: remove dash from model ID while exporting to SMBL format
JonathanRob
approved these changes
Apr 25, 2020
JonathanRob
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. One note: I attempted to rename the ModelFiles directory to modelFiles, though this can be difficult because git generally doesn't recognize case changes like this (requiring two commits with an intermediate "dummy" directory name). If the change doesn't update properly on master, we may need to try doing this directly on that branch. This is, of course, extremely minor.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
Human-GEMwhen exporting to SMBL formatUser guideand relevant websitesspontaneousand TCDB ids to new fields in annotation filehumanGEMRxnAssoc.JSONm10018m,m10018pandm10010nfrom the model and annotation filehumanGEMMetAssoc.JSONannotateModelto adapt to newly added fieldsModeFilestomodelFiles