Skip to content

feat: extensively provide associated external identifiers for rxns and mets - #120

Merged
haowang-bioinfo merged 13 commits into
develfrom
provideExternalAssoc
Jun 4, 2019
Merged

feat: extensively provide associated external identifiers for rxns and mets#120
haowang-bioinfo merged 13 commits into
develfrom
provideExternalAssoc

Conversation

@haowang-bioinfo

Copy link
Copy Markdown
Contributor

Main improvements in this PR:

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected devel as a target branch

@JonathanRob JonathanRob mentioned this pull request Jun 3, 2019
2 tasks
- Use `humanGem` as prefix of output files, instead of `Human1`
@JonathanRob

Copy link
Copy Markdown
Collaborator

Ok, it will be very nice to have all the external ID information organized as you have done here. I have only two small comments:

  1. I'm not sure if you're planning to merge the already generated JSON files directly, or regenerate the JSON files after merging. If you are going to merge them directly, just make sure that they're updated. The reason I'm saying this is because the current humanGemRxnAssoc.JSON file does not appear to be updated with your latest Recon3D ID additions.

  2. How about humanGEMRxnAssoc.JSON instead of humanGemRxnAssoc.JSON (and same with the metabolite file)? Since GEM is the normal usage of the term, I would recommend using it that way.

@haowang-bioinfo

Copy link
Copy Markdown
Contributor Author

@JonathanRob can you specify any "latest Recon3D ID additions" so that they can be retrieved if missing.

@JonathanRob

JonathanRob commented Jun 4, 2019

Copy link
Copy Markdown
Collaborator

@Hao-Chalmers What I meant was that when I ran the getHuman1RxnAssoc script, the new humanGemRxnAssoc.JSON file that it generated did not match the existing humanGemRxnAssoc.JSON file. It seemed that this was because the existing JSON file was an older version that you had generated before commit 7a40123. However, it looks like I ran it right before you updated the file in your next commit, so the issue has been solved.

@haowang-bioinfo
haowang-bioinfo merged commit b11d640 into devel Jun 4, 2019
@haowang-bioinfo haowang-bioinfo mentioned this pull request Jun 12, 2019
@haowang-bioinfo
haowang-bioinfo deleted the provideExternalAssoc branch June 13, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants