-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating to buidler #492
Merged
Merged
Migrating to buidler #492
Changes from 28 commits
Commits
Show all changes
105 commits
Select commit
Hold shift + click to select a range
18ef61b
First start of migration to buidler
jjgonecrypto db992f2
Introducing unit tests
jjgonecrypto 799ab46
trigger build
jjgonecrypto 0a96f7f
trigger build v2
jjgonecrypto e36dda3
Fixing circleci config
jjgonecrypto 72f7c2f
Fixing tests for Buidler
jjgonecrypto 3245577
Migrating delegate approvals to unit
jjgonecrypto 2060de8
SystemStatus to unit
jjgonecrypto c0d8111
Migrating ProxyERC20 to unit
jjgonecrypto 8952e77
Adding fallback test to ProxyERC20
jjgonecrypto 13af456
MixinResolver to unit tests
jjgonecrypto a84ab3c
SupplySchedule a WIP
jjgonecrypto 6f4e487
Renaming common test setup
jjgonecrypto 58e1a96
Minor updates
jjgonecrypto 9a6d903
Fixing coverage
jjgonecrypto 1d901df
Adding back timestamp tests
jjgonecrypto 7d5c336
Upgrading to use timestamp from latest buidler
jjgonecrypto 0baaca2
Merge branch 'develop' into migrating-to-buidler
jjgonecrypto 4213109
SynthetixState
jjgonecrypto 55453a3
Adding more checks to SupplySchedule
jjgonecrypto 71d032e
Better approach to setup
jjgonecrypto 97c3897
Refactoring ExchangeRates to use setup script
jjgonecrypto 75970c2
Adding ABI check to ExchangeRates
jjgonecrypto 908a3e1
Upgrading to solidity-coverage@0.7.3
jjgonecrypto 31ab8a3
Removing unneeded settings
jjgonecrypto 7ef10a2
Removing unneeded settings
jjgonecrypto 2dde295
Revert "Removing unneeded settings"
jjgonecrypto 40e1b4b
Fixing coverage
jjgonecrypto 25c26a2
Fixing coverage tests to use starting timestamp
jjgonecrypto c14f992
New setup script WIP
jjgonecrypto ff96c8a
Better setup
jjgonecrypto 9a19c32
Adding supply
jjgonecrypto 3121fdb
Mock token functionality
jjgonecrypto 617ddcd
Allowing for mocks as address resolver deps
jjgonecrypto 48a0e1e
Depot test fixes
jjgonecrypto 437f9fc
Fixing Depot tests with gas
jjgonecrypto 31952c5
Adding MockSynth for Depot and EtherCollateral
jjgonecrypto 651c7de
Test improvements for EtherCollateral
jjgonecrypto 70e8682
Fixing most of EtherCollateral
jjgonecrypto afe504a
Merge branch 'develop' into migrating-to-buidler
jjgonecrypto 75a55f4
Adding timeout for specifc long-running test
jjgonecrypto 16f34dd
Update to using new unit coverage
jjgonecrypto d839c76
Merge branch 'develop' into migrating-to-buidler
jjgonecrypto 30b04d0
Fixing tests
jjgonecrypto d68facb
Fixing legacy tests
jjgonecrypto aff92e9
Minor fixes
jjgonecrypto 8ba7403
Fixing remaining EtherCollateral test
jjgonecrypto 5005345
Adding more SynthetixState tests
jjgonecrypto a7a6788
Merge branch 'develop' into migrating-to-buidler
jjgonecrypto 8cc103a
RewardEscrow migrated over
jjgonecrypto 485de38
Fixing EtherCollateral
jjgonecrypto 59524a2
Fixing coverage to use PR
jjgonecrypto 84f9d84
Adding larger specific timeouts for coverage
jjgonecrypto 361f1c9
Fixing timeouts for coverage
jjgonecrypto 6fa1888
Synthetix WIP
jjgonecrypto 4c24861
Synthetix more structure
jjgonecrypto d2e0889
Working through Synthetix tests
jjgonecrypto 53cf526
Working thru Synthetix still, now with Issuer
jjgonecrypto 200e1b4
More progress with Synthetix - now with generic mocks
jjgonecrypto 8110123
Supporting exchange() in Synthetix tests
jjgonecrypto afb7563
fixing synthetix.mint()
jjgonecrypto 4b22422
Fixing remainder of Synthetix tests
jjgonecrypto 6da3d13
Fixing broken tests, der
jjgonecrypto d1845a7
Fixing EtherCollateral
jjgonecrypto 75b9ba6
FeePoolState
jjgonecrypto 316fdd0
Simpler implementation
jjgonecrypto cb13e1d
Exchanger WIP
jjgonecrypto 454f379
Exchanger WIP
jjgonecrypto 24d6142
Fixing Exchanger
jjgonecrypto dd3092e
Trimming up RewardEscrow to be a unit test
jjgonecrypto 127cd99
Merge branch 'develop' into migrating-to-buidler
jjgonecrypto c433f9c
Adding Synth test
jjgonecrypto dc2d940
Adding more coverage to Synth test
jjgonecrypto 5bb00e1
Fixing Issuer tests
jjgonecrypto b2280dc
Fixing tests
jjgonecrypto 46f631a
Upgrading to solidity-coverage@0.7.4
jjgonecrypto 0b75b2e
Depot Test Coverage
0164ebd
updateRatesWithDefaults moved
db8c3a9
Merge branch 'migrating-to-buidler' of github.com:Synthetixio/synthet…
40cad9e
Fixing Depot test
jjgonecrypto 2d41fd2
Fixing RewardsDistribution
jjgonecrypto 9744b1c
Porting over MultiCollateralSynth
jjgonecrypto cd453cf
Migrating FeePool tests
jjgonecrypto 1119750
Fixing usages of getDecodedLogs
jjgonecrypto fb803fa
Purgeable Synth porting over
jjgonecrypto 3ce6cbc
Final test :bow:
jjgonecrypto 4f97c3d
Removing truffle migrations
jjgonecrypto d63cf9b
The death of truffle :skull_and_crossbones:
jjgonecrypto cc4be4e
Fixing circleci yml
jjgonecrypto 0da43ed
The removal of ganache :boom:
jjgonecrypto 04bd544
Updating lock
jjgonecrypto e808cd5
Cleaning up invocation
jjgonecrypto 086eea4
Commenting out test failure from coverage
jjgonecrypto e7cdadc
The last vestigates of truffle...
jjgonecrypto 9f19ce4
Moving test files back to test/contracts
jjgonecrypto 3da8719
Cleaning up test helpers
jjgonecrypto e10c938
set default min stake time (#498)
jacko125 c296100
PR feedback
jjgonecrypto c103910
Merge branch 'migrating-to-buidler' of github.com:Synthetixio/synthet…
jjgonecrypto 71e6e22
Removing contract and web3 globals
jjgonecrypto f1cbdb8
Adding chai for assertions and explicit usage of all globals
jjgonecrypto 100c0c7
Cleaning up util usage and test setup
jjgonecrypto b54d60f
Ensuring web3 is properly wrapped into testUtils
jjgonecrypto 7ea3aab
Fixing local testnet test
jjgonecrypto 0ceafab
Cleanup
jjgonecrypto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
const { usePlugin } = require('@nomiclabs/buidler/config'); | ||
|
||
usePlugin('@nomiclabs/buidler-truffle5'); | ||
usePlugin('solidity-coverage'); | ||
|
||
module.exports = { | ||
solc: { | ||
version: '0.4.25', | ||
}, | ||
paths: { | ||
sources: './contracts', | ||
tests: './test/unit', | ||
artifacts: './build/artifacts', | ||
cache: './build/cache', | ||
}, | ||
networks: { | ||
coverage: { | ||
initialDate: '2019-03-06T00:00:00', | ||
url: 'http://localhost:8545', | ||
blockGasLimit: 0x1fffffffffffff, | ||
allowUnlimitedContractSize: true, | ||
}, | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinjmoses solidity-coverage doesn't work with buidlerevm yet. I think here you should add another network..like
... and then run
buidler coverage --network coverage
as the command.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT - your
.solcover.js
specifies port 8545, changing the network url above to reflect that:synthetix/.solcover.js
Line 2 in 2dde295
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much Chris! That fixes it. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for giving support for your Buidler plugin, Chris 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinjmoses Is the coverage difference here (e.g a drop) expected or does it seem like something's not right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov is using the truffle coverage which has dropped as I've migrated tests to buidler, so you can ignore it. I checked out running
npm run coverage:unit
and the results are looking good. Once I move the rest of the tests over tounit
fromcontracts
, I'll update travis to use buidler coverage which will update codecov.