Skip to content

Upgrading solidity-coverage and using new plugin format #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 9, 2020

Conversation

jjgonecrypto
Copy link
Contributor

@jjgonecrypto jjgonecrypto commented Mar 6, 2020

Fixes coverage reports (thanks to @cgewecke) and adds codecov.io reports via travis

@jjgonecrypto
Copy link
Contributor Author

@cgewecke do you happen to have any ideas on the above error with the linker?

@cgewecke
Copy link
Contributor

cgewecke commented Mar 6, 2020

@justinjmoses Will take a look...

@cgewecke cgewecke mentioned this pull request Mar 7, 2020
@cgewecke
Copy link
Contributor

cgewecke commented Mar 7, 2020

@justinjmoses #453 has some possible fixes....

@jjgonecrypto
Copy link
Contributor Author

You're a rockstar @cgewecke 🚀. Do you have an address for donations?

@jjgonecrypto jjgonecrypto marked this pull request as ready for review March 7, 2020 16:18
@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@87f2f76). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #452   +/-   ##
==========================================
  Coverage           ?   87.99%           
==========================================
  Files              ?       47           
  Lines              ?     1941           
  Branches           ?      266           
==========================================
  Hits               ?     1708           
  Misses             ?      233           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f2f76...bdd70a4. Read the comment docs.

@cgewecke
Copy link
Contributor

cgewecke commented Mar 7, 2020

@justinjmoses Oh that's really sweet of you - solidity-coverage 0.7.x was funded by an EF grant and getting it to run on some of the larger, more widely used projects was part of the initial proposal. It's received all the donations it needs, thanks though :)

@jjgonecrypto jjgonecrypto merged commit 2173a79 into develop Mar 9, 2020
@jjgonecrypto jjgonecrypto deleted the adding-coverage branch March 9, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants