-
Notifications
You must be signed in to change notification settings - Fork 608
Deploy kovan-ovm-futures v0.4.0 (Alpha) #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d1d2072
remove price update constraint from order flow
liamzebedee 9c3d4ab
prepare-deploy
liamzebedee ab317d0
add FuturesMarketSettings to releases
liamzebedee 581f6b0
deploy kovan-ovm-futures v0.2.0
liamzebedee d0dc9ed
fixes
liamzebedee cd23e87
unignore deployment.json
liamzebedee b03301c
Merge branch 'futures-implementation' into kovan-ovm-futures
liamzebedee bacaa0a
add FuturesMarketSettings to releases
liamzebedee 21307fc
prepare-deploy
liamzebedee 6b52413
deploy kovan-ovm-futures v0.3.0
liamzebedee 5422e78
Futures position details (#1479)
liamzebedee 6d0128f
Futures accessible margin (#1484)
zyzek 900193b
emit sizeDelta with PositionModified event
liamzebedee a34d5f7
emit sizeDelta with PositionModified event (#1485)
liamzebedee aed9743
deploy kovan-ovm-futures v0.4.0
liamzebedee 1feffad
Merge branch 'futures-implementation' into kovan-ovm-futures
liamzebedee c265c58
test that npmignore will include deployment.json
liamzebedee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # these files are irrelevant outside of a single developer's machine, | ||
| # so no need to persist them in source control | ||
| deployment.json | ||
| owner-actions.json | ||
| owner-actions.json | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| !deployment.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not clear on what this fixes, since you aren't pushing
local-ovm/deployment.json. In general isn't it sensible that updated versions of this aren't committed? Or are we just relying on developers to remember not to commit it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - just figured out that there was a better way of doing this. In #1356 I merged in the local-ovm support so that we could develop locally quickly with the futures-keepers. Turns out that NPM will ignore downloading any files specified by .gitignore - and since we need the deployment.json in a local-ovm development context to fetch local contracts, I tried to include it. Just made a change (and tested it) which overrides the gitignore using npmignore - which will allow us to achieve the above.