Skip to content

Add support for relaying a batch of calls to L2 via the governance bridge #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 19, 2021
Merged

Add support for relaying a batch of calls to L2 via the governance bridge #1466

merged 11 commits into from
Aug 19, 2021

Conversation

i-stam
Copy link
Contributor

@i-stam i-stam commented Aug 17, 2021

No description provided.

@i-stam i-stam marked this pull request as draft August 17, 2021 23:52
@liamzebedee
Copy link
Contributor

Hey @i-stam, dumb q, can the L1-L2 messenger relay msg.value?

@eternauta1337 eternauta1337 mentioned this pull request Aug 18, 2021
Merged
@i-stam
Copy link
Contributor Author

i-stam commented Aug 19, 2021

Hey @i-stam, dumb q, can the L1-L2 messenger relay msg.value?

@liamzebedee , good question. I guess the only way to do it is via an implicit param i.e. get msg.value and wrap it as param on L2.

@i-stam i-stam marked this pull request as ready for review August 19, 2021 17:59
eternauta1337
eternauta1337 approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@eternauta1337 eternauta1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a beauty! Good work @i-stam 🙌

@eternauta1337 eternauta1337 merged commit 718ed9f into governance-bridge Aug 19, 2021
@eternauta1337 eternauta1337 deleted the governance-bridge-batch-relay branch August 19, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternauta1337 eternauta1337 eternauta1337 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-stam @liamzebedee @eternauta1337