Skip to content

Introduces local L1 and L2 integration tests #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 21, 2021
Merged

Conversation

eternauta1337
Copy link
Contributor

@eternauta1337 eternauta1337 commented May 19, 2021

General

  • Deprecates npm run test:prod:ovm
  • Deprecates local ovm CI tests
  • Introduces a new type of "integration" tests that can be run granularly on top of multiple local setups

L2 local integration tests

Runs all tests under test/integration/l2, which test an L2 instance in isolation.

  • Start the Optimism ops tool as described here: https://github.com/ethereum-optimism/optimism#integration-tests (checkout master)
  • Compile the artifacts / contracts, run npx hardhat test:integration:l2 --compile
  • The first time, run npx hardhat test:integration:l2 --deploy
  • After that, while contracts do not change, the --deploy flag can be avoided.

L1 local integration tests

Idem L2 local integration tests, but targeting an isolated L1 instance.

Dual local integration tests

As before, but deploys both L1 and L2 instances and connects them. These tests mainly targets the bridges.

@eternauta1337 eternauta1337 changed the title Refactoring ovm prod tests Introduces local L1 and L2 integration tests May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1274 (19f8b22) into develop (8ae2404) will not change coverage.
The diff coverage is n/a.

❗ Current head 19f8b22 differs from pull request most recent head 8e740cd. Consider uploading reports for the commit 8e740cd to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1274   +/-   ##
========================================
  Coverage    95.53%   95.53%           
========================================
  Files           81       81           
  Lines         5582     5582           
  Branches       677      677           
========================================
  Hits          5333     5333           
  Misses         249      249           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae2404...8e740cd. Read the comment docs.

@eternauta1337 eternauta1337 marked this pull request as ready for review May 21, 2021 11:44
Copy link
Contributor

@jacko125 jacko125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eternauta1337 eternauta1337 merged commit 3b1431d into develop May 21, 2021
@eternauta1337 eternauta1337 deleted the ovm-prod-tests-v2 branch May 21, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants