Remove optimistic unit tests #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tix into remove-ovm-unit-tests
Codecov Report
@@ Coverage Diff @@
## develop #1160 +/- ##
========================================
Coverage 95.62% 95.62%
========================================
Files 76 76
Lines 5413 5413
Branches 661 661
========================================
Hits 5176 5176
Misses 237 237 Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been trying to run our unit tests in "ovm mode" for some time. This involved using an
@ovm-skipmarker in tests that are not applicable in the context of OE.Thing is, trying to do so is hard, and maybe pointless. Hard because the jsvm for optimism does not exactly mimic optimisitic geth, and pointless because producing ovm artifacts and running unit tests with them only validates the ovm compiler? This is certainly not our responsibility.
We might as well remove optimistic unit tests then.