Skip to content

ci: add L2 ovm tests #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 4, 2021
Merged

ci: add L2 ovm tests #1119

merged 12 commits into from
Mar 4, 2021

Conversation

drptbl
Copy link
Contributor

@drptbl drptbl commented Mar 2, 2021

No description provided.

drptbl added 5 commits March 2, 2021 13:47
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Copy link
Contributor

@jjgonecrypto jjgonecrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change with a parameter for a ci command

cd optimism-integration
./up.sh
- cmd-wait-for-rpc
- cmd-wait-for-hardhat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change the port to a parameter and pass it in and then we don't have two separate commands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #1119 (23d6e6d) into develop (6106587) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1119   +/-   ##
========================================
  Coverage    95.62%   95.62%           
========================================
  Files           76       76           
  Lines         5413     5413           
  Branches       661      661           
========================================
  Hits          5176     5176           
  Misses         237      237           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6106587...23d6e6d. Read the comment docs.

drptbl added 5 commits March 4, 2021 00:36
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
@drptbl drptbl requested a review from jjgonecrypto March 4, 2021 16:47
Copy link
Contributor

@jjgonecrypto jjgonecrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼

@drptbl drptbl merged commit 0e85865 into develop Mar 4, 2021
@drptbl drptbl deleted the l2-ovm-tests branch March 4, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants