-
Notifications
You must be signed in to change notification settings - Fork 608
ci: add L2 ovm tests #1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add L2 ovm tests #1119
Conversation
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change with a parameter for a ci command
.circleci/config.yml
Outdated
cd optimism-integration | ||
./up.sh | ||
- cmd-wait-for-rpc | ||
- cmd-wait-for-hardhat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we change the port to a parameter and pass it in and then we don't have two separate commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinjmoses done!
Codecov Report
@@ Coverage Diff @@
## develop #1119 +/- ##
========================================
Coverage 95.62% 95.62%
========================================
Files 76 76
Lines 5413 5413
Branches 661 661
========================================
Hits 5176 5176
Misses 237 237 Continue to review full report at Codecov.
|
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🏼
No description provided.