Change error logic

Synthetixio · Sep 7, 2023 · 74259ec · 74259ec
1 parent 9f86186
commit 74259ec
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/commands/metamask.js b/commands/metamask.js
@@ -1269,7 +1269,14 @@ const metamask = {
       .count();
 
     while (txIndex >= visibleTxsCount) {
-      await playwright.metamaskWindow().getByText('View more').click();
+      try {
+        await playwright.metamaskWindow().getByText('View more').click();
+      } catch (error) {
+        log('[openTransactionDetails] Clicking "View more" failed!');
+        throw new Error(
+          `Transaction with index ${txIndex} is not found. There are only ${visibleTxsCount} transactions.`,
+        );
+      }
 
       visibleTxsCount = await playwright
         .metamaskWindow()
@@ -1279,12 +1286,6 @@ const metamask = {
         .count();
     }
 
-    if (txIndex >= visibleTxsCount) {
-      throw new Error(
-        `Transaction with index ${txIndex} is not found. There are only ${visibleTxsCount} transactions.`,
-      );
-    }
-
     await playwright
       .metamaskWindow()
       .locator(mainPageElements.activityTab.completedTransaction(txIndex))