Skip to content

Commit

Permalink
net/llc: make opt unsigned in llc_ui_setsockopt()
Browse files Browse the repository at this point in the history
The members of struct llc_sock are unsigned so if we pass a negative
value for "opt" it can cause a sign bug.  Also it can cause an integer
overflow when we multiply "opt * HZ".

CC: stable@kernel.org
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
error27 authored and davem330 committed Sep 13, 2010
1 parent a505b3b commit 339db11
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/llc/af_llc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1024,7 +1024,8 @@ static int llc_ui_setsockopt(struct socket *sock, int level, int optname,
{
struct sock *sk = sock->sk;
struct llc_sock *llc = llc_sk(sk);
int rc = -EINVAL, opt;
unsigned int opt;
int rc = -EINVAL;

lock_sock(sk);
if (unlikely(level != SOL_LLC || optlen != sizeof(int)))
Expand Down

0 comments on commit 339db11

Please sign in to comment.