-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
SABnzbd: Update to 4.5.1 and migrate to Python 3.12 #6431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c43b6f4 to
24eefbd
Compare
|
Install and update seem to be successful on DSM 6: Install LogUpgrade LogService Log |
ddd3bf0 to
7e063c7
Compare
|
@mreid-tt sabnzbd is also a candiate for hybrid packaging (python311/python312)? |
No, I don’t believe so. Things seem to build okay for DSM 6 with python 3.12. Was there something I missed? |
Sorry, my fault, this restriction of only for packages with numpy wheel 🛞 🛞 🛞 |
|
Wonder if this is a good idea, hybrid packages. Thinking of the future maintenance burden... If building exceptional/complex wheels remains the same, fine, but if it ends up diverting I'm not sure. Anyway, future will tell |
|
Was wondering about the status of this? Should I test it? |
Hey, SABnzbd appears to be working fine from my testing. You can likely verify it after additional framework changes are completed and I rebase this PR to incorporate them. These updates support other Python packages requiring NumPy and various cross-compiled wheels. See #6421. |
|
Hey @th0ma7, I’ve reworked this PR using @hgy59's requirements script and set One thing I noticed is that |
80864ab to
cdca90a
Compare
cdca90a to
182cf5f
Compare
|
Hey @Safihre, this should be ready to merge now with the latest update for SABnzbd. I'd appreciate your review and approval for merging. For my testing, install and update seem to be successful on DSM 6: Install LogUpgrade LogService Log |
|
Thanks! Seems good to me. |
|
Thank you! |
Description
This PR includes the following:
Fixes #
Checklist
all-supportedcompleted successfullyType of change