rutorrent: Update v4.3.7 to v5.1.12 and migrate to Python 3.12 #6404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump PHP requirement to 8.2
smaarn
changed the title
hgy59
reviewed
Jan 18, 2025
Contributor
|
@smaarn I already have a local update to rutorrent 4.3.9 including updates for
and work on spk/rutorrent in progress to:
If you don't mind I could add the updated dependencies soon and help with the spk definitions later... |
Contributor
Author
@hgy59 by all means, do ! This PR was just to kick off the upgrade work in a "minimal" effort mode (e.g. have the build passing, play with things to see if there needs to be more advanced config changes...). |
- update cross/libtorrent-rakshasa from v0.13.8 to v0.14.0 (drop specific commit by hash) - update cross/rtorrent from v0.9.8 to v0.10.0 (drop specific commit by hash) - update cross/xmlrpc-c from v1.51.06 to v1.59.03 - spk/rutorrent: - drop rutorrent.sc (same as default, generated by spksrc.spk.mk) - adjust changelog
- add cross/screen5 (requires DSM 7, i.e. std c17)
… rutorrent/upgrade-5.1
Contributor
|
@smaarn dependencies updated (and master merged into this) Thanks to #6255 the github prepare action takes now less than one minute including the source download. For spk/rutorrent files, further investigation is required. @mreid-tt shall we try to update this package for DSM 7.1 with PHP 8.0 and DSM 7.2 with PHP 8.2? |
Contributor
@hgy59, we can try both yes. I am a bit unsure why we are bumping the PHP version however since the release notes for ruTorrent don't seem to make any special mention of a minimum PHP 8 requirement. If this is in fact needed then a build for different versions of PHP will show errors when run with incompatible versions (similar to #6229). |
Contributor
Author
@mreid-tt actually I was under the impression that I couldn't install PHP 7.4 on my DSM (7.2). Turns out I was wrong. We can definitely avoid upgrading then. I'm not sure, though, about a "build" for different versions of PHP causing incompatibilities (it's only runtime dependencies from what I recall), right ? I will revert the PHP upgrade anyway since it would minimize the "risk" of this upgrade. |
7 tasks
Contributor
Author
|
Status: installation successful but get the following warnings at startup: |
Fix installation directory for dumptorrent and scrapec
hgy59
reviewed
Feb 1, 2025
Fix configuration of dump plugin
PR Review: simplify installation of dumptorrent and scrapec binaries
Fix PLIST
This reverts commit 80a7014.
Contributor
Author
|
Summary of situation:
@hgy59 do you recall what were the reasoning behind the version upgrades and why you picked those specific versions (and not others) ? |
Contributor
cross/libtorrent-rakshasa
cross/rtorrent
cross/xmlrpc-c
what else? |
This reverts commit 9b347c4.
Contributor
Author
Will be having a crack at reverting the upgrade of libtorrent and rtorrent to the "unstable" version and see how it goes. It turns out that 0.9.8 is the latest "stable" version and the recommended one for rutorrent so we may not even have a choice, but let's try with the 0.10.0 version. |
Contributor
|
@smaarn, I've completed the change to the plugin restore function. I've also bumped to rutorrent to 5.1.12. Finally, I've migrated the package to Python 3.12. Will see how the build completes and then do some testing. |
mreid-tt
changed the title
Contributor
|
Install and update are successful on DSM 7: Install LogUpgrade LogService Log |
Contributor
th0ma7
requested changes
Jun 17, 2025
Contributor
I initially had it set to the 5.2.x branch, but I noticed there are other packages that might also need updates. I can handle updating the download references and version numbers, but several of them include patch files and explicit PLIST files, which would be difficult for me to update without a development environment. I'm happy to take care of the basic version updates, but I’d need assistance with the more detailed components. |
This reverts commit 51c9783.
Contributor
|
Gotcha, maybe then just updating the few trivial dependencies (if any) and leaving the rest for a subsequent PR? As this is already a big update on its own for the rutorrent package. |
mreid-tt
changed the title
mreid-tt
changed the title
Contributor
I've done some testing with the latest versions and these are the findings:
As such, I've rolled these back and left everything else updated and am running some final tests. |
Contributor
|
@smaarn, I believe we have a working version now following my testing. I'm still getting one error in the log: But this does not seem to affect the app functionality. All plugins (including ratio) are loaded and enabled. EDIT: Correction to my previous message. After performing a clean uninstall and reinstall, the error no longer appears. It’s possible that some cached data in my browser from earlier tests may have contributed to the issue. For now, the startup is running clean. 
|
mreid-tt
added
the
status/published
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
all-supportedcompleted successfullyType of change
Status
dumpplugin (adddumptorrent)ratioplugin loading/tmp/errors.log)