Skip to content

Resolved issue with adding an invalid member to ReferencedFields list #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 24, 2023

Conversation

playlend
Copy link
Collaborator

Made a change in TranslateSelect method to not add members to ReferencedFields list if we're doing SelectAll or if element size of the member is 0. Prior to this change, the members that were added to ReferencedFields list were causing a problem during creation of a sparse object when joining files over xfserver.

@hippiehunter
Copy link
Contributor

this looks like a semi real failure of some sort in the tests

 Error Message:
   Class Initialization method Services.Test.UnitTests.RemoteIOTests.ClassInit threw exception. System.ComponentModel.Win32Exception: An error occurred trying to start process 'C:\agent\_work\HarmonyCore.Test\tools\MultXfConTestSetup.bat' with working directory 'C:\agent\_work\1\s\Services.Test\bin\Release\net6.0'. The system cannot find the file specified..
  Stack Trace:
      at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at Services.Test.UnitTests.RemoteIOTests.ClassInit(TestContext Context) in C:\agent\_work\1\s\Services.Test\UnitTests\RemoteIOTests.dbl:line 38

@hippiehunter hippiehunter marked this pull request as ready for review May 24, 2023 18:01
@hippiehunter hippiehunter merged commit 3f4b983 into master May 24, 2023
@hippiehunter hippiehunter deleted the referencedFieldsIssue branch May 24, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants