Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker/VM] use libinsighttoolkit5-dev as opposed to building ITK #886

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KrisThielemans
Copy link
Member

This should speed things up, as well as make future builds faster

@KrisThielemans
Copy link
Member Author

KrisThielemans commented Mar 10, 2024

The job with -DUSE_SYSTEM_HDF5=OFF fails with https://github.com/SyneRBI/SIRF-SuperBuild/actions/runs/8218475321/job/22475381522?pr=886#step:10:29217

[ 80%] Linking CXX executable cstir_test4
/usr/bin/ld: /home/runner/install/lib/libIO.a(GEHDF5Wrapper.cxx.o): undefined reference to symbol '_ZNK2H510H5Location11openDataSetEPKcRKNS_15DSetAccPropListE@@HDF5_CPP_1.10.3'
/usr/bin/ld: /lib/x86_64-linux-gnu/libhdf5_serial_cpp.so.103: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
gmake[5]: *** [src/xSTIR/cSTIR/tests/CMakeFiles/cstir_test4.dir/build.make:366: src/xSTIR/cSTIR/tests/cstir_test4] Error 1

This could be because STIR found the system ITK (which will use system HDF5). That would create confusion with the one we build ourselves. However, it shouldn't have happened as it's currently run with USE_SYSTEM_ITK=OFF .

I see some other things about potential conflicts at run-time, but I think those are ok

CMake Warning at /usr/local/share/cmake-3.28/Modules/UseSWIG.cmake:939 (add_library):
  Cannot generate a safe runtime search path for target _stir because files
  in some directories may conflict with libraries in implicit directories:

    runtime library [libITKTestKernel-5.2.so.1] in /usr/lib may be hidden by files in:
      /home/runner/install/lib

So, I'm not sure... @casperdcl @paskino any idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant