Skip to content

Conversation

@WillPapper
Copy link
Contributor

@WillPapper WillPapper commented Oct 12, 2024

Fixes Foundry install, which migrates away from the more finicky OP Stack version. Also adds easy op-up/down aliases for use in the shell

Includes a number of other small improvements, like a default extension set and better $PATH handling

This should fix issues with the Optimism install having $PATH problems
Installing node can fail with:
download from https://nodejs.org/dist/v18.20.4/node-v18.20.4-linux-x64.tar.xz failed
./configure: 10: exec: python: not found
nvm: install v18.20.4 failed!
./configure: 10: exec: python: not found

As a fix, we'll install Python before Node rather than after
Also replace Justfile copying in favor of bash command aliases
@WillPapper WillPapper marked this pull request as draft October 12, 2024 07:45
@WillPapper WillPapper marked this pull request as ready for review October 12, 2024 08:34
It will be used heavily so it's good to keep it online
@WillPapper WillPapper changed the title feat(dev-container): Fix Foundry install and add devnet aliases feat(dev-container): Improved dev container configuration Oct 12, 2024
Copy link
Contributor

@ericvelazquez ericvelazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@WillPapper WillPapper merged commit a97f346 into main Oct 15, 2024
@WillPapper WillPapper deleted the wpapper/dev-container-fixes branch October 15, 2024 14:35
tsite added a commit that referenced this pull request May 21, 2025
…e-by-line-review' into seq-928-patch

remove certora invariant #8 which appears to be outdated - a bulk tx
should succeed even if individual txs fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants