- 
                Notifications
    You must be signed in to change notification settings 
- Fork 0
feat(dev-container): Improved dev container configuration #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    This should fix issues with the Optimism install having $PATH problems
Installing node can fail with: download from https://nodejs.org/dist/v18.20.4/node-v18.20.4-linux-x64.tar.xz failed ./configure: 10: exec: python: not found nvm: install v18.20.4 failed! ./configure: 10: exec: python: not found As a fix, we'll install Python before Node rather than after
Also replace Justfile copying in favor of bash command aliases
This is the bare minimum for working with our repos, and will be useful
It will be used heavily so it's good to keep it online
              
                    jorgemmsilva
  
              
              approved these changes
              
                  
                    Oct 14, 2024 
                  
              
              
            
            
              
                    ericvelazquez
  
              
              approved these changes
              
                  
                    Oct 15, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
    
  tsite 
      added a commit
      that referenced
      this pull request
    
      May 21, 2025 
    
    
      
  
    
      
    
  
…e-by-line-review' into seq-928-patch remove certora invariant #8 which appears to be outdated - a bulk tx should succeed even if individual txs fail.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes Foundry install, which migrates away from the more finicky OP Stack version. Also adds easy op-up/down aliases for use in the shell
Includes a number of other small improvements, like a default extension set and better $PATH handling