Skip to content

Fix: make deploy-metafiller-storage deployment script #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2024
Merged

Fix: make deploy-metafiller-storage deployment script #37

merged 3 commits into from
Oct 26, 2024

Conversation

@calebguy
Copy link
Collaborator

@calebguy calebguy commented Oct 26, 2024 •
edited
Loading

Ticket

What does this PR do?

  • Summary: Provide a brief description of what this PR implements, the problem it solves, or the feature it introduces. Include relevant context as needed.
  • Key Changes:
    • Updates the makefile script for deploying the MetafillerStorage contract to include the l3 chain ID into the constructor

Does this PR introduce any breaking changes (API/schema)?

  • Yes/No:
    • No

Do any environment variables need to be updated or added before deployment?

  • Yes/No:
    • No

How can this PR be tested?

@calebguy calebguy marked this pull request as ready for review October 26, 2024 17:57
@calebguy calebguy changed the title Fix: make deploy-metafiller-storage Fix: make deploy-metafiller-storage deployment script Oct 26, 2024
gustavoguimaraes
gustavoguimaraes approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@gustavoguimaraes gustavoguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calebguy calebguy merged commit 88f28fb into main Oct 26, 2024
@calebguy calebguy deleted the fix/makefile-deploy-metafiller-storage branch October 26, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gustavoguimaraes gustavoguimaraes gustavoguimaraes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calebguy @gustavoguimaraes