Skip to content

Conversation

@RomanHodulak
Copy link
Contributor

@RomanHodulak RomanHodulak commented Oct 23, 2024

Ticket

What does this PR do?

  • Summary: Resolve build errors preventing forge build to succeed.
  • Key Changes:
    • Reinitialize submodules added by forge
    • Rename source files to make consistent casings with source code references which causes issues on platforms with case sensitives file systems

Does this PR introduce any breaking changes (API/schema)?

  • No

Do any environment variables need to be updated or added before deployment?

  • No

How can this PR be tested?

These commands have to succeed:

forge install
forge build

… with casing used in the source code

Causes problems on platforms where filenames are case sensitive
The repository root contains `.gitmodules` created by running `forge install`
@linear
Copy link

linear bot commented Oct 23, 2024

SEQ-223 Developer can't build metabased contracts

As a part of an effort of running the devcontainer, we need to deploy metabased contracts.

During that I was unable to build them using instructions in the readme.

AC:

  • forge build runs successfully

@gustavoguimaraes gustavoguimaraes merged commit 39bc99f into main Oct 23, 2024
@gustavoguimaraes gustavoguimaraes deleted the roman/SEQ-223/fix-contracts-sources branch October 23, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants