Skip to content

Conversation

@RomanHodulak
Copy link
Contributor

@RomanHodulak RomanHodulak commented Oct 17, 2024

Ticket

What does this PR do?

  • Summary: Introduces the concept of application "metrics." for collecting data about the application usage. The main implementation technology is prometheus.
  • Key Changes:
    • Add Metrics trait.
    • Make send raw tx endpoint dependent on Metrics
    • Record every call on the endpoint
    • Add endpoint for prometheus scraper

Does this PR introduce any breaking changes (API/schema)?

  • *No

Do any environment variables need to be updated or added before deployment?

  • No

How can this PR be tested?

Every call to eth_sendRawTransaction is counted and added to the output of metrics endpoint.

@linear
Copy link

linear bot commented Oct 17, 2024

SEQ-199 Prometheus metrics + instrumentation

Ahead of the private testnet, we need to have endpoints and any other relevant paths instrumented and emitting basic metrics usable by node operators.

AC:

  • Support an open source observability stack, like Prometheus
  • Main flows (e.g. send_raw_transaction() instrumented)

@RomanHodulak RomanHodulak marked this pull request as ready for review October 17, 2024 18:18
Base automatically changed from roman/SEQ-203/env-config to main October 17, 2024 19:53
@RomanHodulak RomanHodulak force-pushed the roman/SEQ-199/metrics branch from 2c76c3f to 437f806 Compare October 17, 2024 19:55
Copy link
Collaborator

@daniilrrr daniilrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RomanHodulak RomanHodulak merged commit 1c2b151 into main Oct 17, 2024
2 checks passed
@RomanHodulak RomanHodulak deleted the roman/SEQ-199/metrics branch October 17, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants