-
Notifications
You must be signed in to change notification settings - Fork 0
feat: use op receiptsFetcher on BlocksReceiptsByNumbers #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SEQ-182 Implement fallback for getting block receipts
Currently we use the non-standard but much more performant "eth_getBlockReceipts" RPC method to get all the receipts for a block. Since this is non-standard however, some RPCs do not support it geth has a component with a bunch of logic and fallbacks around getting receipts: https://github.com/ethereum-optimism/optimism/blob/4f1e8a7036e1f85fb1754ca1bb08a461c7c50ac4/op-service/sources/receipts_rpc.go#L61 We should either re-use this component or duplicate some similar logic for if that method isnt available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an excellent change, good catch on the non-standard method being used! 💪
left a few comments about best practices and how we organize the code
Ticket
What does this PR do?
receiptsFetcherin therpc-clientstruct.receiptsFetcheris imported from the op source codeDoes this PR introduce any breaking changes (API/schema)?
Do any environment variables need to be updated or added before deployment?
How can this PR be tested?