Gus/cleanup #11
Gus/cleanup #11
Conversation
* get rid of reth-exex folder * organize contracts folder
* get rid of reth-exexs * organize contracts folder
| @@ -1,6 +1,6 @@ | |||
| [submodule "contracts/lib/forge-std"] | |||
There was a problem hiding this comment.
I think this file can now be deleted? since we have the .gitmodules file at project root
There was a problem hiding this comment.
This is Foundry specific submodules. It needs these for tests to work.
There was a problem hiding this comment.
Also foundry keep the run-* files as historical deployment artifacts. I will keep these in case we need to check which contracts were deployed to which chains while we are testing.
metabased-contracts/.env.example
Outdated
| @@ -0,0 +1 @@ | |||
| ETH_PRIVATE_KEY= No newline at end of file | |||
There was a problem hiding this comment.
Can we fill this with the devnet default? https://docs.optimism.io/chain/testing/dev-node#additional-info. This also works for local Anvil nodes
That way, auto-deployment to the devnet will work easily. Likewise, we should default the RPC URL to the devnet (http://localhost:9545)
There was a problem hiding this comment.
Sounds good. Will do.
What does this PR do?
remove obsolete files from reth-exex folder plus organize contracts folder