fix(svm): fixup some arithmetics in the interpreter

[Rexicon226]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/vm/interpreter.zig	96.66%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/vm/tests.zig	98.68% <100.00%> (+0.01%)	⬆️
src/vm/interpreter.zig	97.12% <96.66%> (-0.56%)	⬇️

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dnut]

Above, there is this:

const lhs: u64 = if (opcode.is64()) lhs_large else @as(u32, @truncate(lhs_large));

So, isn't it already truncated? What does the additional truncate do?

[Rexicon226]

It provides a different result type to the shift amount truncate. Honestly I should re-design this code to be generic over the bitsize of the instruction, so that I don't need to represent 32-bits in a 64-bit value, and then reduce it at each place.

[Rexicon226]

Did that here: 24ae663

This turned out way nicer than I thought, I had the idea to do this when I was first writing this implementation, but for some reason didn't do it. It also caught a bug in the mul32 implementation :).

[Rexicon226]

• feat(svm): implement basic compute budget logic #624
• fix(svm): fixup some arithmetics in the interpreter #620 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.