feat(vote-program): Update commission instruction #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…am-update-commission
0xNineteen
requested changes
Mar 18, 2025
Comment on lines
+505
to
+506
| /// Agave https://github.com/anza-xyz/solana-sdk/blob/69edb584ac17df2f5d8b5e817d7afede7877eded/vote-interface/src/instruction.rs#L415 | ||
| fn updateCommission( |
There was a problem hiding this comment.
dont think this permalink makes sense - it should be this right? https://github.com/anza-xyz/agave/blob/24e62248d7a91c090790e7b812e23321fa1f53b1/programs/vote/src/vote_state/mod.rs#L743
Comment on lines
+36
to
+40
| pub const allow_commission_decrease_at_any_time = | ||
| Pubkey.parseBase58String("5x3825XS7M2A3Ekbn5VGGkvFoAg5qrRWkTrY4bARP1GL") catch unreachable; | ||
|
|
||
| pub const commission_updates_only_allowed_in_first_half_of_epoch = | ||
| Pubkey.parseBase58String("noRuG2kzACwgaY7TVmLRnUNPLKNVQE1fb7X55YWBehp") catch unreachable; |
There was a problem hiding this comment.
can we declare constants these at the top of the struct
Comment on lines
+71
to
+76
| pub fn getSysvar( | ||
| self: *const InstructionContext, | ||
| comptime T: type, | ||
| ) InstructionError!T { | ||
| return self.tc.sysvar_cache.get(T) orelse InstructionError.UnsupportedSysvar; | ||
| } |
There was a problem hiding this comment.
do we use this anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commission is the percentage that represents what part of a rewards payout should be given to a VoteAccoun, while the rest would be distributed to the delegates.
This PR implements the instruction for updating a vote account's commission. It also adds feature sets which are needed for this instruction.