feat(fuzz): fuzz with random multithreaded reads for accountsdb #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
kprotty
reviewed
Feb 13, 2025
src/accountsdb/fuzz.zig
Outdated
| @@ -145,6 +155,17 @@ pub fn run(seed: u64, args: *std.process.ArgIterator) !void { | |||
| var pubkeys_this_slot = std.AutoHashMap(Pubkey, void).init(allocator); | |||
| defer pubkeys_this_slot.deinit(); | |||
|
|
|||
| for (0..8) |i| { | |||
| _ = try std.Thread.spawn(.{}, readRandomAccountThread, .{ | |||
There was a problem hiding this comment.
should .detach() the thread handles to avoid leaking their resources.
There was a problem hiding this comment.
addressed in 972fb91
Sobeston
force-pushed
the
sobe/accountsdb/multithread-fuzz-2
branch
from
d58a6c9 to
972fb91
Compare
kprotty
reviewed
Mar 7, 2025
| defer tracked_accounts_lg.unlock(); | ||
| tracked_accounts.deinit(); | ||
|
|
||
| for (threads[0..spawned_threads]) |thread| thread.join(); |
There was a problem hiding this comment.
Should prob join threads outside the writeLock to avoid a deadlock: reader misses alive, goes to readLock; writer alive=false, writeLocks, waits on reader to join; reader readLock is waiting on writer writeLock
Maybe move the defer { alive=false; join threads } after the defer deinit. Could also get rid of the errdefer detach(); spawned = 0 down below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #532 to target main