refactor(consensus:vote_listener): Rename VoteListener to VoteProcessor, make single-threaded #1005
+428
−734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InKryption
force-pushed
the
ink/vote-listener-one-thread
branch
3 times, most recently
from
a48474c to
ec8f1a5
Compare
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
InKryption
force-pushed
the
ink/vote-listener-refactors
branch
from
788139b to
9722609
Compare
InKryption
force-pushed
the
ink/vote-listener-one-thread
branch
2 times, most recently
from
60f6a8a to
f87a0b7
Compare
InKryption
force-pushed
the
ink/vote-listener-refactors
branch
from
9722609 to
be1fcd7
Compare
InKryption
force-pushed
the
ink/vote-listener-one-thread
branch
from
f87a0b7 to
54c4531
Compare
InKryption
changed the base branch from
ink/vote-listener-refactors
to
graphite-base/1005
InKryption
force-pushed
the
ink/vote-listener-one-thread
branch
from
54c4531 to
1662cdd
Compare
InKryption
force-pushed
the
graphite-base/1005
branch
from
be1fcd7 to
0b1ea5a
Compare
InKryption
changed the base branch from
graphite-base/1005
to
ink/vote-listener-refactors
InKryption
changed the base branch from
ink/vote-listener-refactors
to
graphite-base/1005
* As said, make the now-so-called VoteCollector a single threaded construct by default, a simple struct with some state and a method to collect and process votes. * Also disentangle a large amount of state in replay/consensus that can be parameterized, akin to "unmanaging" managed data structures. * Add an error log where before an error was being ignored. * Simplify/improve some tests.
InKryption
force-pushed
the
graphite-base/1005
branch
from
0b1ea5a to
b27a235
Compare
InKryption
force-pushed
the
ink/vote-listener-one-thread
branch
from
1662cdd to
60f335b
Compare
InKryption
force-pushed
the
ink/vote-listener-one-thread
branch
from
ad8d9d8 to
074c9d7
Compare
these are no longer used across any threads, so they don't need to be guarded by a rwmux
InKryption
force-pushed
the
ink/vote-listener-one-thread
branch
from
074c9d7 to
e454768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.