Merged
Conversation
ddbaptiste
requested changes
Feb 20, 2025
Member
ddbaptiste
left a comment
ddbaptiste
left a comment
There was a problem hiding this comment.
Tentatively requesting changes for the one review comment, but I'm looking for discussion on it, because I'm not against an alternative. If we want specific comments not to be truncated to fit the 80-character limit, we can use the delimiters
// clang-format off
...
// clang-format on
ddbaptiste
approved these changes
Feb 21, 2025
Member
ddbaptiste
left a comment
ddbaptiste
left a comment
There was a problem hiding this comment.
Per discussion about the current limitations of clang-format versions available to us, approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating code per style guide and adding CI Workflow for Clang Styling