-
Notifications
You must be signed in to change notification settings - Fork 18
Updated OperatorEnum to use any data type (not just Numbers) #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
9798f58
eval_tree_array (generic) reshapes output
grezde 656d232
added type interface so non-generic eval works with any type
grezde 4b6d5e8
added oher types to OperatorEnum
grezde c7ad68c
fixed most tests
grezde a5efcd4
added example as test
grezde 5468282
removed unnecessary lines in this branch
grezde 8587599
reset Project.toml
grezde da1886f
Update src/Evaluate.jl
gca30 8d2797e
Apply suggestions from code review
gca30 a3d14e9
applied formatting, all other suggestions from pull request
gca30 225ba4d
generalized Optim, removed outdated tests
gca30 a8003ce
added bradcast operator support to expand_operators and showing expre…
gca30 08b20f6
Merge branch 'master' into pr/gca30/85
MilesCranmer ae404c3
remove old parsing test
MilesCranmer c788b38
append_number_constants no longer uses push
gca30 41c6d37
reformat
gca30 60dc72e
applied merge
gca30 7fbe0e6
Apply suggestions from code review
gca30 85d8b25
reformat
gca30 bdf4ad0
type interface suggestions
gca30 a638f84
reformat
gca30 1213786
rename scalar utility functions
MilesCranmer f4ab375
specialize type in `get_scalar_constants`
MilesCranmer 150552d
fix tests
MilesCranmer 16fa343
simplify use of interface
MilesCranmer 81fd233
rename `index_constants` to `index_constant_nodes`
MilesCranmer 7b62bd8
ci: compat with deprecated function names
MilesCranmer 1c0d935
deps: remove unused TestItems.jl in main package
MilesCranmer f2217bd
style: formatting
MilesCranmer 0284229
style: move TypeInterface imports to top of import list
MilesCranmer 2189c7f
fix: update precompile function names
MilesCranmer 70c46fc
style: import all extensions at once for parallel precompilation
MilesCranmer f8e5acf
style: update name to `set_scalar_constants!` in benchmarks
MilesCranmer 0ad3c93
ci: add extra benchmark for parametric nodes
MilesCranmer 308c5d1
style: clean up ParametricExpression internal methods
MilesCranmer 0b8bd43
feat: add `ValueInterface` to formalize interface
MilesCranmer 6fae896
refactor: rename to `ValueInterface`
MilesCranmer 9347092
refactor: simplify `Max2Tensor`
MilesCranmer 398b640
fix: equality check between dims
MilesCranmer 571518c
fix: name of ValueInterfaceModule
MilesCranmer bebbe18
refactor: simplify `Max2Tensor` further
MilesCranmer e2e9b21
fix: `ValueInterface` checker of packing
MilesCranmer 1b1a674
test: full `ValueInterface` for `Max2Tensor`
MilesCranmer 5fa74fc
refactor: `Max2Tensor` to more general `DynamicTensor`
MilesCranmer 455e80f
test: fix more generic `DynamicTensor`
MilesCranmer 6e3db19
refactor: clean up use of `is_valid` throughout library
MilesCranmer 1c878f2
refactor: propagate inbounds to unpacking and packing
MilesCranmer 0c8aab9
refactor: clean up broadcasted operators
MilesCranmer 5ce69c5
feat: warn for `BroadcastFunction`
MilesCranmer b162f75
feat: use safer `lock` syntax
MilesCranmer 1b576fe
feat: only warn if defining helper functions
MilesCranmer 7ff927b
fix: mark `@unstable`
MilesCranmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.