-
Notifications
You must be signed in to change notification settings - Fork 18
Overload Optim.optimize for ::Node
#30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbe2cef to
5a8e0b2
Compare
Contributor
Pull Request Test Coverage Report for Build 4915532924
💛 - Coveralls |
Contributor
Benchmark Results
|
Contributor
|
I don't think I've needed this but I can see how it could be useful. |
Member
Author
|
The Enzyme interface would make this nicer: MilesCranmer/SymbolicRegression.jl#254 |
[Diff since v0.14.0](v0.14.0...v0.14.1) **Merged pull requests:** - Add built-in random sampling (#57) (@MilesCranmer) - Add better errors for `rand` (#58) (@MilesCranmer)
ac3f7ff to
00ace76
Compare
This was referenced Jan 25, 2024
6e2c0cf to
339c619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #27.
This implements a memory efficient
Optim.optimizefor::Nodeset to the initial value. For example:This gives us:
and is quite fast:
(recall that this
tree's structure is completely variable)@AlCap23 @ChrisRackauckas maybe this is useful for your stuff too?