Permit n-argument operators #127
Open
+1,853
−983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See JuliaLang/julia#55076 for details
MilesCranmer
commented
May 10, 2025
Comment on lines
+19
to
+20
| function OperatorEnum(binary_operators::Tuple, unary_operators::Tuple) | ||
| return OperatorEnum((unary_operators, binary_operators)) |
There was a problem hiding this comment.
Should add a depwarn here
Pull Request Test Coverage Report for Build 14946536677Details
💛 - Coveralls |
Benchmark Results
|
MilesCranmer
commented
May 11, 2025
Comment on lines
+292
to
+297
| _children = if !isnothing(l) && isnothing(r) | ||
| @assert isnothing(children) | ||
| (l,) | ||
| elseif !isnothing(l) && !isnothing(r) | ||
| @assert isnothing(children) | ||
| (l, r) |
This was from `tree` being treated as an iterator!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens up DynamicExpressions.jl to D-degree nodes via an additional type parameters. This is still a work-in-progress, but I wanted to track the TODO's here.
TODO:
Either split types, orget generic type to match existing performance forConsider using::Union{Nothing,N}rather thanRefBase.Cartesianversion.land.r(temporarily set these to be errors)Introduce aliasNode{T} = NNode{T,2}for full backwards compatibility