fix(core): critical memory leak in pendingFileChanges #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root cause: In lowMemoryMode (default for PersistentStorage),
`pendingFileChanges` array was never cleared because
`incrementalEngine` is null, causing the early return in
`rebuildSearchIndex()` to skip cleanup.
Each file change pushed {newContent: full file content} to
the array, accumulating 100+GB over time in long-running
processes.
Fixes:
- Clear pendingFileChanges in rebuildSearchIndex early return
- Wrap rebuild logic in try/finally for exception safety
- Clear pendingFileChanges in stopWatch()
- Add CodebaseIndexer.close() for proper resource cleanup
- Fix VectorStorage.close() to actually close LanceDB connection
- Add graceful shutdown to MCP server calling indexer.close()
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pendingFileChangesarray was never cleared in lowMemoryModeCodebaseIndexer.close()methodVectorStorage.close()to actually release LanceDB connectionRoot Cause
In
rebuildSearchIndex(), whenincrementalEngineis null (lowMemoryMode default), the function returned early without clearingpendingFileChanges. This caused the array to grow unbounded with each file change event.Test plan