Upgrade to WinzouStateMachineBundle ^0.4.1 #99
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winzou/state-machine-bundle 0.4.1 fixes an incompatibility with Symfony 4. Allowing users to upgrade the state-machine-bundle make using Symfony 4 easier.
Replace sm.factory with SM\Factory\FactoryInterface. None of the three services in the compiler pass are retrieved directly from the container, thus they do not need to be public.
ahilke
changed the title
lchrusciel
approved these changes
Jun 27, 2019
Contributor
|
👍 Although this might be a BC break. |
Contributor
|
We'd need to add a compiler pass which provides BC with 0.3 behaviour ( |
Contributor
|
Or probably an alias will just do. |
Contributor
|
An alias in a compiler pass, since we'd modify services coming from outside resource bundle. |
pamil
added a commit
that referenced
this pull request
Jan 2, 2020
…0 & remove support for <4.4 (pamil) This PR was merged into the 1.6-dev branch. Discussion ---------- Closes #134, closes #99. We need to upgrade DoctrineBundle and FOSRestBundle (which has no support for Symfony 5 yet). A bit of dependencies maintenance done here + a reliable build setup. Commits ------- 474979c Fix testing multiple Symfony versions & remove support for 4.3 a43600e Allow for Winzou/StateMachineBundle ^0.4 f5f6fe9 Fix specs to be compatible with Twig 3 222c2bd Drop support for Symfony ^3.4, add support for Symfony ^5.0 ab2379f Do not require the component package in the bundle (it is replaced by it) 936c891 Remove unneccessary dependency on sylius/locale 1ab2b10 Increase memory limit for Composer 64a13d6 Allow failures for Symfony 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winzou/state-machine-bundle 0.4.1 fixes an incompatibility with Symfony 4. Allowing users to upgrade the state-machine-bundle make using Symfony 4 easier.