Skip to content

Symfony workflow #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Zales0123 merged 30 commits into from
Jan 17, 2022
Merged

Symfony workflow #203

Zales0123 merged 30 commits into from
Jan 17, 2022

Conversation

@loic425
Copy link
Member

@loic425 loic425 commented Oct 15, 2020 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner October 15, 2020 09:58
loevgaard
loevgaard reviewed Oct 15, 2020
View reviewed changes
@loic425 loic425 force-pushed the feature/symfony-workflow branch from b0304c5 to ce85e95 Compare October 21, 2020 15:34
@loic425 loic425 force-pushed the feature/symfony-workflow branch 2 times, most recently from a91baab to 036a01b Compare November 6, 2020 07:59
@loic425 loic425 force-pushed the feature/symfony-workflow branch from ec3e9d4 to a8160be Compare November 13, 2020 08:24
@loic425 loic425 changed the title [WIP] Symfony workflow Symfony workflow Nov 13, 2020
@loic425 loic425 force-pushed the feature/symfony-workflow branch from 0182a2a to bbcd5b4 Compare November 13, 2020 09:35
@loic425
Copy link
Member Author

loic425 commented Nov 16, 2020

@pamil @lchrusciel @Zales0123 I'm waiting for your review. 🤞

@loic425
Copy link
Member Author

loic425 commented Nov 24, 2020 •
edited
Loading

@pamil Just to note here what I asked to you on private message.

Do you want me to execute these tests with a winzou state machine configuration?

@loic425 loic425 force-pushed the feature/symfony-workflow branch 5 times, most recently from eea5719 to 66b7bff Compare November 27, 2020 15:47
@loic425
Copy link
Member Author

loic425 commented Dec 1, 2020

@pamil Winzou state machine is now tested with same phpunit tests.

pamil
pamil reviewed Dec 2, 2020
View reviewed changes
@loic425 loic425 force-pushed the feature/symfony-workflow branch 2 times, most recently from d4799cf to 10b2b56 Compare December 8, 2020 10:45
@loic425
Copy link
Member Author

loic425 commented Dec 8, 2020

@pamil I've just finished refactoring this PR with new test app architecture.

@loic425
Copy link
Member Author

loic425 commented Jan 20, 2021

@pamil @lchrusciel @AdamKasp
Now 1.7 has been released, can we finish this PR?

@loic425 loic425 force-pushed the feature/symfony-workflow branch 2 times, most recently from 15e9047 to 77a4cc4 Compare April 9, 2021 13:22
@loic425
Copy link
Member Author

loic425 commented Jun 10, 2021

ping @lchrusciel @pamil

@Zales0123 Zales0123 added the Feature New feature proposals. label Dec 20, 2021
@Zales0123
Copy link
Contributor

Zales0123 commented Dec 20, 2021

Hi, @loic425 😄 As you're doing great with PRs today 💃 maybe it would be worth returning to this one? I will dig into it and do some tests, but it seems promising and finally mergeable in the very nearest future 🖖

@loic425 loic425 force-pushed the feature/symfony-workflow branch from 77a4cc4 to 325901b Compare December 20, 2021 13:57
@loic425
Copy link
Member Author

loic425 commented Dec 20, 2021

Hi, @loic425 😄 As you're doing great with PRs today 💃 maybe it would be worth returning to this one? I will dig into it and do some tests, but it seems promising and finally mergeable in the very nearest future 🖖

done 👍

Zales0123
Zales0123 reviewed Jan 10, 2022
View reviewed changes
Copy link
Contributor

@Zales0123 Zales0123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some few final comments and it will be ready to merge finally :) 🖖 Especially this one is important

@loic425 loic425 force-pushed the feature/symfony-workflow branch from b5d77b2 to 90eadd4 Compare January 11, 2022 09:17
loic425 added 22 commits January 13, 2022 10:16
@loic425 loic425 force-pushed the feature/symfony-workflow branch from 6b314ec to 7bb2f60 Compare January 13, 2022 10:15
@loic425 loic425 force-pushed the feature/symfony-workflow branch from 1671127 to 02d09db Compare January 13, 2022 10:22
@Zales0123 Zales0123 merged commit b87c88d into Sylius:master Jan 17, 2022
@Zales0123
Copy link
Contributor

Zales0123 commented Jan 17, 2022

Finally 🎉 Thank you, @loic425, astonishing work! 🚀

@loic425 loic425 deleted the feature/symfony-workflow branch January 17, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@pamil pamil pamil left review comments

@loevgaard loevgaard loevgaard left review comments

@vvasiloi vvasiloi vvasiloi left review comments

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature New feature proposals.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@loic425 @Zales0123 @pamil @loevgaard @lchrusciel @vvasiloi