Fix build #181
Merged
Fix build #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Sep 8, 2020
loic425
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
Member
Author
|
@lchrusciel What do you think about these fixes? |
lchrusciel
reviewed
Sep 8, 2020
Contributor
lchrusciel
left a comment
lchrusciel
left a comment
There was a problem hiding this comment.
Hey Loic,
thanks for your work and fixes seem ok. However, I'm wondering why do we need to bump the state machine version? Not a big deal, but we are using 0.3 in Sylius right now.
composer.json
Outdated
| "symfony/yaml": "^4.4|^5.0", | ||
| "willdurand/hateoas-bundle": "^2.0", | ||
| "winzou/state-machine-bundle": "^0.3|^0.4" | ||
| "winzou/state-machine-bundle": "^0.4.3" |
Member
Author
There was a problem hiding this comment.
There's a bug on winzou with dependencies between state-machine and state-machine bundle. Maybe there's something better to do:
"winzou/state-machine-bundle": "^0.3.2|^0.4.3"
I'm gonna try that.
Member
Author
There was a problem hiding this comment.
@lchrusciel But I think we have to improve CI configuration to test these two state machine versions.
lchrusciel
approved these changes
Sep 9, 2020
Contributor
|
Thanks, Loïc! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.