Allow FOS rest-bundle 2 #180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the bundle was upgraded to be compatible with fos/rest v3 but that was about removing the View->setTemplate calls and replacing them with twig rendering. all other sylius bundles are using v2 and this causes incompatibility.
Contributor
Author
|
reference to the PR: #167 |
Contributor
|
Hey Jan, thanks for your PR. However, we need to fix the main build before we can go anywhere further. |
Closed
Member
|
@lchrusciel @Zales0123 Could we close this one? we'll deprecate Fos rest usage soon. |
Member
|
@esserj thank you for contribution and sorry for late reply. 🙏 At this moment rest-bundle 2.0 depends on SF 3/4, which are no longer supported versions, so I'm going to close it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bundle was upgraded to be compatible with fos/rest v3
but that was about removing the View->setTemplate calls
and replacing them with twig rendering.
all other sylius bundles are using v2 and this causes incompatibility.
This will allow you to release a 1.7 version of the resource bundle, something
currently not possible due to that incompatibility