Skip to content

Add php7.4 and symfony 4.4 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dannyvw wants to merge 2 commits into from
Closed

Add php7.4 and symfony 4.4 #118

dannyvw wants to merge 2 commits into from

Conversation

@dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Dec 4, 2019

No description provided.

lchrusciel
lchrusciel approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Danny.

thanks for the contribution. Could you take a look at failing tests?

@dannyvw
Copy link
Contributor Author

dannyvw commented Dec 9, 2019 •
edited
Loading

@lchrusciel Sure, but akeneo/phpspec-skip-example-extension does not allow phpspec 6. I have created a PR.

I see that psalm is already fixed in #114.

@pamil pamil mentioned this pull request Jan 1, 2020
Merged
pamil added a commit that referenced this pull request Jan 1, 2020
@pamil
minor #129 Add support for PHP 7.4 and Symfony 4.4 (, dannyvw, pamil)
8d62fc7 
This PR was merged into the 1.6-dev branch.

Discussion
----------

Building on top of @dannyvw's work in #118.

Commits
-------

411dd2a Add php7.4 and symfony 4.4
9a5fc57 Update phpspec
5b77a77 Require dev-master behat/transliterator in dev to make tests passing
@pamil
Copy link
Contributor

pamil commented Jan 1, 2020

Continued and merged in #129, thanks!

@pamil pamil closed this Jan 1, 2020
@dannyvw dannyvw deleted the travis branch January 1, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lchrusciel lchrusciel lchrusciel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dannyvw @pamil @lchrusciel