[Maintenance] Add Sylius Plus Info command #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
reviewed
May 22, 2024
There was a problem hiding this comment.
The command and its output looks ok 💪🏻, but after thinking about it and discussing it internally, I would be in favour of moving it to Sylius/Sylius after all. Mainly so that when users set up a new project, they do not have an unnecessary command at the start. In addition, we may yet use it in Sylius itself 🤔.
mpysiak
force-pushed
the
SYL-3508-add-sylius-plus-info-command
branch
from
20263f8
to
93bb2dd
Compare
GSadee
approved these changes
May 23, 2024
|
However, this PR should wait for the next Sylius releases and we should bump up Sylius version in composer |
Wojdylak
approved these changes
Jun 11, 2024
|
Thanks, Michał! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console view after creating new project with composer: