Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make init error with docker check #1072

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: make init error with docker check #1072

merged 1 commit into from
Nov 15, 2024

Conversation

sonbui00
Copy link
Contributor

@sonbui00 sonbui00 commented Nov 14, 2024 •
edited
Loading

FIx issue when run make init

make[1]: *** [docker-compose-check] Error 1

Fix #1018

@sonbui00
fix: make init error with docker check
eabe46e 
Signed-off-by: Son Bui <sonbv00@gmail.com>
@sonbui00 sonbui00 requested review from a team as code owners November 14, 2024 03:27
@GSadee GSadee added the Docker Docker-related issues and PRs. label Nov 15, 2024
@GSadee GSadee merged commit 27a33af into Sylius:2.0 Nov 15, 2024
4 checks passed
@GSadee
Copy link
Member

GSadee commented Nov 15, 2024

@sonbui00, thank you for the contribution! Could you maybe open the same fix for the 1.14 branch?

@sonbui00 sonbui00 mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wojdylak Wojdylak Wojdylak approved these changes

Assignees
No one assigned
Labels
Docker Docker-related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect check in Makefile
3 participants
@sonbui00 @GSadee @Wojdylak