1081 problems with userstories GitHub syncrosantion#1083
Draft
ShahdLala66 wants to merge 10 commits into
Draft
Conversation
…erstories-github-syncrosantion
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend user story workflow to better handle deletion (including a new confirmation modal) and adjusts synchronization behavior when user stories are edited or removed, particularly for Jira-backed sessions.
Changes:
- Added a dedicated “Delete Story” confirmation modal with Jira-specific warning text.
- Adjusted deletion flow so stories are removed from state only after certain server outcomes (and for manual mode).
- Changed Jira description edit behavior to auto-fill a placeholder title when missing.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/views/SessionPage.vue | Updates user story sync/delete logic (Jira/manual) and state updates. |
| frontend/src/locales/en.json | Adds English i18n strings for the delete confirmation modal. |
| frontend/src/components/UserStoryDescriptions.vue | Changes description edit handling and Jira missing-title behavior. |
| frontend/src/components/UserStoryDeleteModal.vue | Introduces new delete confirmation modal component with Jira-specific copy. |
| frontend/src/components/UserStories.vue | Wires delete confirmation modal into the user stories list and updates delete flow. |
Comments suppressed due to low confidence (1)
frontend/src/views/SessionPage.vue:660
responseis not consistently typed: in some branches it can be a number (204), but later the code unconditionally checksresponse.status. Ifresponseis numeric, this will throw at runtime. Consider normalizingresponseto a consistent shape (e.g., always an AxiosResponse-like object) or guarding the.statusaccess with a type check and handling the204case first.
console.log('Server Error, either token is invalid or something is wrong.')
response = await apiService.updateUserStory(JSON.stringify(us[idx]));
}
}
if (response.status === 200) {
this.toast.success(
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
626
to
629
| if (doRemove) { | ||
| if (us[idx].id === null) { | ||
| response = 204; | ||
| } else { |
Comment on lines
+631
to
+633
| if (response.status === 200) { | ||
| us.splice(idx, 1); | ||
| } |
| if (this.isJiraSelected && us[idx].description) { | ||
| us[idx].description = j2m.to_jira(us[idx].description); | ||
| } | ||
| console.log('Server Error, either token is invalid or something is wrong.') |
Comment on lines
+111
to
+113
| const UserStoryIdLocally = idx + 1; | ||
| this.userStories[idx].title = "Unknown Issue " + UserStoryIdLocally; | ||
| this.publishChanges(idx); |
Comment on lines
+5
to
+8
| :title="t('page.session.during.modal.deleteTitle')" | ||
| :ok-title="t('page.session.during.modal.buttons.ok')" | ||
| :cancel-title="t('page.session.during.modal.buttons.cancel')" | ||
| @ok="confirm" |
| "bodyPart1": "Are you sure you want to remove ", | ||
| "bodyPart2": " from your current session?", | ||
| "deleteTitle": "Delete Story", | ||
| "defaultDeleteInfo": "Are you sure you want to delete this story? This action cannot be undone", |
| /> | ||
| <UserStoryDeleteModal | ||
| v-model:is-visible="showDeleteConfirmModal" | ||
| :story-mode="storyMode" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.