Skip to content

Conversation

aunncodes
Copy link

Fixes the previously broken crafting system, with a major rework to the entirety of the recipe files.

Fixes the previously broken crafting system, with a major rework to the entirety of the recipe files.
@Swofty-Developments Swofty-Developments self-requested a review August 5, 2025 09:43
Took 14 minutes
@Swofty-Developments
Copy link
Owner

The bugs in the crafting system definitely are fixed with this PR, though the parsing is very very slow.
image

@aunncodes
Copy link
Author

The bugs in the crafting system definitely are fixed with this PR, though the parsing is very very slow. image

strange, I'm not sure why it would've gotten slower. I guess in this case I'm making more checks to validate their craft and make sure their are no extra items. Someone else can check to see if there are any optimizations that could be made, but I'm not too sure.

@ArikSquad
Copy link
Contributor

fix-1.diff
This might fix the performance issues if you apply this diff as a patch to ShapedRecipe

@aunncodes
Copy link
Author

Just saw this, thanks I'll test this when I'm home tommorow.

Adds the fixes from ArikSquad, should optimize it a bit.

Co-Authored-By: AriDev <75741608+ArikSquad@users.noreply.github.com>
@aunncodes
Copy link
Author

Added on the new commit, should hopefully fix some of the parsing lag. It's hard for me to tell on my end, as I have a very laggy server in general for some reason.

@aunncodes
Copy link
Author

@Swofty-Developments did you get a chance to test this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants