Skip to content

Fix startTransition demo #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Fix startTransition demo #16

merged 1 commit into from
Jun 15, 2021

Conversation

gaearon
Copy link

@gaearon gaearon commented Jun 15, 2021

  1. Uses a newer alpha and removes the caret (a caret is bad for prereleases because you can get a wrong hash due to alphabetical sorting)
  2. Adds memo around Pythagoras that's necessary for an urgent update to actually skip rendering the tree. Alternatively, you could move the slider urgent state updates into child components. But this works fine too.

Note: this wasn't the only issue, CRA also needed updating to work around a bug. It's not in this PR so this "Preview" is still slow.

@vercel
Copy link

vercel bot commented Jun 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/swizec/react-fractals/FaYpSivKQSmtTxsjRwwSjURESc4r
✅ Preview: https://react-fractals-git-fork-gaearon-react-18-swizec.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants