Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added russian and ukrainian translation to strings.json :p #19

Merged
merged 4 commits into from
Aug 23, 2020
Merged

Added russian and ukrainian translation to strings.json :p #19

merged 4 commits into from
Aug 23, 2020

Conversation

yukisnowflake
Copy link
Contributor

Amm, hey, I opened this PR. Can you check and merge it?

Copy link
Member

@pedrofracassi pedrofracassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Languages should be in alphabetical order. Please move ru to the end of the file :)

@pedrofracassi
Copy link
Member

Also please be aware that these won't work right away due to #14. But it's good to have the translation ready for when we fix it :)

@yukisnowflake
Copy link
Contributor Author

@pedrofracassi Hmm, sorry for the offtopic, but it seems you also have something broken
image

@pedrofracassi
Copy link
Member

@pedrofracassi Hmm, sorry for the offtopic, but it seems you also have something broken

Yeah, something seems to be broken on our side. I'll get it fixed.

In the meantime, please pull the latest changes to your fork. I've pushed a change that should get that Lint action to pass.

@pedrofracassi
Copy link
Member

There we go. The 502 error you were getting should be fixed now.

pedrofracassi
pedrofracassi previously approved these changes Aug 23, 2020
@pedrofracassi pedrofracassi dismissed their stale review August 23, 2020 19:30

Changes were made

@pedrofracassi
Copy link
Member

Hey, please make sure that the strings follow our string guidelines. The ones you've added don't seem to match the ones on the client:

image

@yukisnowflake
Copy link
Contributor Author

image

@pedrofracassi
Copy link
Member

pedrofracassi commented Aug 23, 2020

Well, I guess mine are different then :p

Thanks for your Pull Request!

@pedrofracassi pedrofracassi merged commit 1ee412e into SwitchbladeBot:master Aug 23, 2020
@yukisnowflake
Copy link
Contributor Author

@pedrofracassi If you send an invite, Discord will show you "Вы отправили приглашение" (You have sent an invitation), so "Вы были приглашены присоединиться к серверу" (You have been invited to join a server) is correct here

@yukisnowflake yukisnowflake changed the title Added russian translation to strings.json :p Added russian and ukrainian translation to strings.json :p Aug 23, 2020
@pedrofracassi
Copy link
Member

Oh, ok

@yukisnowflake
Copy link
Contributor Author

yukisnowflake commented Aug 23, 2020

@pedrofracassi
Copy link
Member

Yup, I've fixed that on the master branch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants