-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added russian and ukrainian translation to strings.json :p #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Languages should be in alphabetical order. Please move ru
to the end of the file :)
Also please be aware that these won't work right away due to #14. But it's good to have the translation ready for when we fix it :) |
@pedrofracassi Hmm, sorry for the offtopic, but it seems you also have something broken |
Yeah, something seems to be broken on our side. I'll get it fixed. In the meantime, please pull the latest changes to your fork. I've pushed a change that should get that Lint action to pass. |
Update ci.yml
There we go. The 502 error you were getting should be fixed now. |
Hey, please make sure that the strings follow our string guidelines. The ones you've added don't seem to match the ones on the client: |
Well, I guess mine are different then :p Thanks for your Pull Request! |
@pedrofracassi If you send an invite, Discord will show you "Вы отправили приглашение" (You have sent an invitation), so "Вы были приглашены присоединиться к серверу" (You have been invited to join a server) is correct here |
Oh, ok |
Also check this commit: https://github.com/vladciphersky/invidget/commit/dc0b9eff8fe77f384cd0650d9b49062c72a840e6 >___< |
Yup, I've fixed that on the master branch. Thanks! |
Amm, hey, I opened this PR. Can you check and merge it?