Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook after the options were intialized #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fredericbirke
Copy link
Contributor

We boot the same container many times to simulate field device behaviour and need to hook into the ResourceOptions, so that container specific adaptions can be made (e.g. set a different name/id for each container, that is booted from the same image)

@swisslife-bot
Copy link

swisslife-bot commented Feb 25, 2021

CLA assistant check
All committers have signed the CLA.

@fredericbirke
Copy link
Contributor Author

fredericbirke commented Feb 25, 2021

The whitespace changes with the XML comments is a little bit weird, I don't seem to have those changes locally.

And it seems like I'm not able to fix those changes :D Do you work on windows machines? But even if, the changes are not a line ending change. Weird...

@glucaci
Copy link
Member

glucaci commented Feb 27, 2021

If I understand good this can be a feature to start a specific container and not to start from an image, is that right?
And than we can specify the options on each start rather than modify them after creation.

@fredericbirke
Copy link
Contributor Author

Yes exactly. This enables you to configure your container before it starts up by modifying the options. This is especially useful, if you start multiple containers from the same image, that need different configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants