feat: prepare Legacy sessions phase out #4119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
You can access the deployment of this PR at https://ci-renku-4119.dev.renku.ch |
lorenzo-cavazzi
force-pushed
the
lorenzo/v1-sessions-warnings
branch
from
9887f72 to
1ccd765
Compare
lorenzo-cavazzi
changed the title
leafty
reviewed
Aug 12, 2025
leafty
reviewed
Aug 12, 2025
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
olevski
approved these changes
Aug 12, 2025
leafty
requested changes
Aug 12, 2025
Member
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
Flag is not working, see deployment
leafty
approved these changes
Aug 12, 2025
Member
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
OK, just a minor visual bug to fix sometimes
Member
Author
😱 Thanks for spotting that! The fix is here SwissDataScienceCenter/renku-ui#3799 |
Collaborator
|
Tearing down the temporary RenkuLab deployment for this PR. |
olevski
pushed a commit
that referenced
this pull request
Aug 13, 2025
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
olevski
added a commit
that referenced
this pull request
Aug 13, 2025
* chore: create release 2.6.0 * feat: add support for git revision and context dir options to image builds (#4102) * fix: upgrade amalthea to 0.20.1 (#4123) Changes the order of the proxies so that sessions where the base URL path is stripped to "/" still works. * feat: upgrade data service to 0.53.0 (#4124) * chore: add buildpack base images (#4086) * chore: publish base images on tag events (#4125) * chore(deps): bump tmp (#4121) Bumps the npm_and_yarn group with 1 update in the /cypress-tests directory: [tmp](https://github.com/raszi/node-tmp). Updates `tmp` from 0.2.1 to 0.2.4 - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.1...v0.2.4) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.4 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: prepare Legacy sessions phase out (#4119) Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch> * feat: disable legacy sessions by default --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tasko Olevski <tasko.olevski@sdsc.ethz.ch> Co-authored-by: Rok Roškar <roskarr@ethz.ch> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com> Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch> Co-authored-by: Tasko Olevski <olevski90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new value
ui.client.supportLegacySessionsto turn off the Legacy sessions on the UI side -- see lorenzo/v1-sessions-warningsThis PR includes the latest UI version 4.6.0 with a bunch of other minor improvements and bugfixes
/deploy extra-values=ui.client.supportLegacySessions=false