feat: allow custom session egress network policies #4097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
You can access the deployment of this PR at https://ci-renku-4097.dev.renku.ch |
leafty
reviewed
Jul 17, 2025
olevski
force-pushed
the
feat-allow-custom-session-netpol
branch
from
8362a79 to
e407b86
Compare
The stuff we had hardcoded is not general enough to work on Openshift or in cases where the Renku deployment is not exposed to the internet.
olevski
force-pushed
the
feat-allow-custom-session-netpol
branch
from
e407b86 to
3308b5d
Compare
leafty
approved these changes
Jul 22, 2025
olevski
dismissed
sgaist’s stale review
The changes have been addressed. It is holding up the mernging of the PR so I dismissed this.
Collaborator
|
Tearing down the temporary RenkuLab deployment for this PR. |
olevski
added a commit
that referenced
this pull request
Jul 23, 2025
* chore: create release 2.5.0 * feat: upgrade amalthea to 0.20.0 (#4090) * feat: make swagger-ui image configurable (#4089) This allows to customize swagger in the same way as other components. Useful for example when deploying on OpenShift where the default image cannot run due to security constraints. * chore(deps): bump brace-expansion (#4048) Bumps the npm_and_yarn group with 1 update in the /cypress-tests directory: [brace-expansion](https://github.com/juliangruber/brace-expansion). Updates `brace-expansion` from 1.1.11 to 1.1.12 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com> * chore: swap swagger services order to show data service first (#4093) * feat: update renku-ui to 4.4.0 (#4100) * chore: bump renku-ui to 4.4.0 * test: update group acceptance test * feat: update renku-gateway to 1.6.0 (#4094) The gateway can now run without GitLab when `enableV1Services` is set to `false`. The cypress acceptance tests are updated to support correctly running when `enableV1Services=false`. * chore(deps): bump brace-expansion (#4101) Bumps the npm_and_yarn group with 1 update in the /cypress-tests directory: [brace-expansion](https://github.com/juliangruber/brace-expansion). Updates `brace-expansion` from 1.1.11 to 1.1.12 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: remove unused notebook service (#4095) * feat: allow custom session egress network policies (#4097) The policies we had hardcoded is not general enough to work on Openshift or in cases where the Renku deployment is not exposed to the internet. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tasko Olevski <tasko.olevski@sdsc.ethz.ch> Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com> Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stuff we had hardcoded is not general enough to work on Openshift or in cases where the Renku deployment is not exposed to the internet.
/deploy