feat: show a warning when about to shut down a session #3928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-3928.dev.renku.ch |
lorenzo-cavazzi
force-pushed
the
lorenzo/keep-session-alive
branch
from
0d71db1 to
28d4d6e
Compare
lorenzo-cavazzi
force-pushed
the
lorenzo/keep-session-alive
branch
from
28d4d6e to
c061ee9
Compare
lorenzo-cavazzi
force-pushed
the
lorenzo/keep-session-alive
branch
from
6e3c268 to
5e8096b
Compare
ciyer
requested changes
Dec 18, 2025
Contributor
ciyer
left a comment
ciyer
left a comment
There was a problem hiding this comment.
This looks good and works well!
I have one small suggestion for an improvement and a question.
client/src/features/sessionsV2/SessionShowPage/ShowSessionPage.tsx
Outdated
Show resolved
Hide resolved
client/src/features/sessionsV2/SessionShowPage/ShowSessionPage.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows a modal to warn users when a session is flagged as inactive by Amalthea and set for termination.
Clicking the button will reset the counter.
Reference on Notion: https://www.notion.so/renku/Explicit-session-culling-28c0df2efafc800d92dcd2d9bf5f98b6
/deploy amalthea-sessions=main renku-data-services=eikek/build/session-last-interaction