feat: add session alerts #3919
Merged
feat: add session alerts #3919
+935
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-3919.dev.renku.ch |
wesjdj
force-pushed
the
add-session-alerts
branch
from
a5b2f08 to
57fdd41
Compare
leafty
requested changes
Dec 9, 2025
leafty
requested changes
Dec 9, 2025
client/src/features/sessionsV2/SessionShowPage/SessionAlerts.tsx
Outdated
Show resolved
Hide resolved
client/src/features/sessionsV2/SessionShowPage/SessionAlerts.tsx
Outdated
Show resolved
Hide resolved
client/src/features/sessionsV2/SessionShowPage/SessionAlerts.tsx
Outdated
Show resolved
Hide resolved
client/src/features/sessionsV2/SessionShowPage/SessionAlerts.tsx
Outdated
Show resolved
Hide resolved
* fix: proper API spec * update code * fix * fix lint
leafty
reviewed
Dec 10, 2025
client/src/features/sessionsV2/SessionShowPage/SessionAlerts.tsx
Outdated
Show resolved
Hide resolved
leafty
reviewed
Dec 10, 2025
leafty
reviewed
Dec 10, 2025
Member
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
This can be fixed in a fix PR:
| if (!alerts || alerts.length === 0) { | ||
| return ( | ||
| <div> | ||
| <Button |
Member
There was a problem hiding this comment.
Note: this should not be a button or it should open something that says "no alerts".
Member
|
@wesjdj should we merge this? |
Member
|
Just fyi the backend counterpart has been merged in the data services and the backend components in the data services that are needed to support this will be released in 2.12.0. So the ui part can go out then or in a later release. |
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/deploy extra-values=enableInternalGitlab=false