Skip to content

fix: websocket problems when legacy is disabled #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jul 11, 2025

extra-values=enableV1Services=false

/deploy renku=ciyer/no-legacy extra-values=enableV1Services=false

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3759.dev.renku.ch

@ciyer ciyer marked this pull request as ready for review July 11, 2025 12:05
@ciyer ciyer requested a review from a team as a code owner July 11, 2025 12:05
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does the fix work?

@ciyer
Copy link
Contributor Author

ciyer commented Jul 11, 2025

how does the fix work?

This is the code from App.jsx where the web socket is initialized:

    let webSocketUrl = props.client.uiserverUrl + "/ws";
    if (webSocketUrl.startsWith("http"))
      webSocketUrl = "ws" + webSocketUrl.substring(4);

You will see why the webSocketUrl was incorrect when the field on the client object is called uiServerUrl.

@ciyer ciyer merged commit d29b615 into main Jul 11, 2025
21 checks passed
@ciyer ciyer deleted the ciyer/no-legacy-ws-fix branch July 11, 2025 12:14
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants