feat(client): add WebSocket channel setup #2013
Conversation
|
You can access the deployment of this PR at https://renku-ci-ui-2013.dev.renku.ch |
lorenzo-cavazzi
force-pushed
the
1338client-b-websokets
branch
from
cc8e44d to
e4108b0
Compare
| function handleUserInit(data: Record<string, unknown>, webSocket: WebSocket, model: any): boolean { | ||
| if (data?.message && (data.message as string).toLowerCase().includes("connection established")) { | ||
| // send request for getting the UI version | ||
| webSocket.send(JSON.stringify(new WsMessage({ requestServerVersion: true }, "init"))); |
There was a problem hiding this comment.
Could you not do this?
| webSocket.send(JSON.stringify(new WsMessage({ requestServerVersion: true }, "init"))); | |
| webSocket.send((new WsMessage({ requestServerVersion: true }, "init")).toString()); |
There was a problem hiding this comment.
This pattern is repeated in every send function of both the client and server WebSocket channel. I changed it everywhere so that all the JSON.stringify(<content>) become (<content>).toString().
|
Thank you for the review! I addresses the points you mentioned, and improved the logic to open/close the channel so that we won't miss the session cookies (or retry shortly after when that happens) |
- start the WebSocket channel - handle messages and termination fix #1338
lorenzo-cavazzi
force-pushed
the
1338client-b-websokets
branch
from
1bc0c1d to
dcd865e
Compare
|
Thanks for the review! Could you re-approve? |
- start the WebSocket channel - handle messages and termination fix #1338
lorenzo-cavazzi
force-pushed
the
1338client-b-websokets
branch
from
dcd865e to
23c5af4
Compare
- start the WebSocket channel - handle messages and termination fix #1338
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This PR adds the client-side logic for WebSocket.
The WebSocket channel is set up and it gets re-created in case of recoverable errors (to be further expanded), and it listens to incoming messages.
Once a new message comes, it checks for a suitable handler and executes it.
Mind that we save minimal data to the store for the WebSocket channel itself, but the handlers can modify any part of the model.
This fully moves the logic to check for UI version updates to the WebSocket channel. It's also a good example of how we can send all the required data through the channel, although we probably want to avoid this behavior in most cases where we need to get a lot of data.
How to test
Open the network tab and verify that the WebSocket channel is created and information about the client version is sent regularly.
Further development
There will be a follow-up issue to finish and enable the (already partially coded) logic for finding session updates through the WebSocket channel.
/deploy renku-gateway=master #persist
fix #1338