feat(server): websocket #1888
Closed
feat(server): websocket #1888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ui-1888.dev.renku.ch |
lorenzo-cavazzi
commented
Jun 14, 2022
Comment on lines
+157
to
+158
| // ! Should we Upgrade here? | ||
| // ! Verify the Origin since same-origin policy doesn't work for WS |
There was a problem hiding this comment.
This is a nice-to-have for extra security, but probably not that urgent
lorenzo-cavazzi
commented
Jun 14, 2022
|
|
||
| function configureWebsocket(server: ws.Server, authenticator: Authenticator, storage: Storage): void { | ||
| server.on("connection", async (socket, request) => { | ||
| // ! Should we Upgrade here? |
There was a problem hiding this comment.
The answer seems to be "yes". Otherwise, I get inconsistent results when authenticating using the cookies.
REFERENCE: https://github.com/websockets/ws#client-authentication
lorenzo-cavazzi
commented
Jun 14, 2022
Comment on lines
+161
to
+163
| const sessionId = request.headers["ui-server-session"] ? | ||
| request.headers["ui-server-session"] as string : | ||
| ""; |
There was a problem hiding this comment.
This logic is wrong for the real-world application. We should actually get the "ui-server-session" section from the Cookies -- there is no "ui-server-session" header
|
Superseded by #2004 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a draft⚠️
For the documentation, check the README file in the
/server/src/websocketfolder.Websocket channel available at
wss://<URL>/ui-server/ws/deploy #persist
re #1338